Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): refining error fallback for different components when catching errors #4459

Merged
merged 6 commits into from
May 28, 2024

Conversation

2013xile
Copy link
Contributor

@2013xile 2013xile commented May 22, 2024

Add ErrorFallback.Modal

20240527144808_rec_

Blocks

image

Fields

20240527145425_rec_

Action.Popover

image

Action.Drawer

image

Action.Modal

image

SchemaSettings

20240527145048_rec_

Toolbar

20240527162756_rec_

Copy link

height bot commented May 22, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-4332" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@2013xile 2013xile requested review from dream2023 and chenos May 22, 2024 10:45

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Tests results for "E2E"

11 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/belongsTo/schemaInitializer.test.ts:64:7 › form item & view form › configure fields
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:30:7 › where grid card block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/details-single/__e2e__/schemaInitializer.test.ts:29:7 › where single data details block can be added › popup opened by clicking on the button for the relationship field
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-calendar/src/client/__e2e__/schemaInitializer.test.ts:14:7 › where can be added › page
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/block.test.ts:53:7 › file collection block › correctly size

976 passed, 29 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@chenos chenos merged commit 98a8e68 into main May 28, 2024
8 checks passed
@chenos chenos deleted the T-4332 branch May 28, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants