Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iframe support variables #4512

Merged
merged 69 commits into from
Jun 5, 2024
Merged

feat: iframe support variables #4512

merged 69 commits into from
Jun 5, 2024

Conversation

katherinehhh
Copy link
Contributor

Description

Motivation

Key changes

  • Frontend
  • Backend

Test plan

Suggestions

Underlying risk

Showcase

Copy link

height bot commented May 28, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Jun 5, 2024

Tests results for "E2E"

1 failed
❌ [chromium] › core/client/src/modules/blocks/data-blocks/form/e2e/form-create/schemaSettings1.test.ts:277:7 › creation form block schema settings › save block template & using block template

11 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/block.test.ts:53:7 › file collection block › correctly size
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:65:9 › table block schema settings › enable drag and drop sorting › enable drag and drop sorting
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:359:9 › table block schema settings › connect data blocks › should not lose the filtering function when dragging and connecting
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers › TableActionInitializers should add bulk update
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaInitailizer.test.ts:13:5 › BlockInitializers should add gantt block
⚠️ [chromium] › plugins/@nocobase/plugin-workflow-action-trigger/src/client/__e2e__/configuration1.test.ts:24:7 › Configuration page to configure the Trigger node › Form Submit Button Binding Workflow Add Data Trigger
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:30:7 › where grid card block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-action-duplicate/src/client/__e2e__/schemaSettings.test.ts:14:7 › direct duplicate & copy into the form and continue to fill in › direct duplicate

976 passed, 29 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@katherinehhh katherinehhh merged commit ec15f9e into main Jun 5, 2024
8 of 9 checks passed
@katherinehhh katherinehhh deleted the T-4370 branch June 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants