Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix Variable.TextArea style #4513

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(client): fix Variable.TextArea style #4513

merged 1 commit into from
May 29, 2024

Conversation

mytharcher
Copy link
Contributor

Description

Border and other style of Variable.TextArea disappeared.

image

Steps to reproduce

  1. Add a calculation node in workflow.
  2. Open node configuration drawer.

Expected behavior

The input text area should has border and other styles.

Actual behavior

Styles disappeared.

Related issues

None.

Reason

49d0082#diff-015b8e211b486e3d5847258410762fc9da59abfc28055848abf1bc9dde29003bR238

Solution

Add useInputStyle('ant-input') for custom component.

Copy link

height bot commented May 28, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-4376" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Tests results for "E2E"

11 flaky ⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:30:7 › where grid card block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-action-custom-request/src/client/__e2e__/schemaSettings.test.ts:13:7 › custom request action › edit button
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/block.test.ts:53:7 › file collection block › correctly size
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/createLocalStorage.test.ts:15:7 › file manager › add new local storage
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/collectionEventTrigger/configuration3.test.ts:85:7 › Configuration page disable enable › Collection Event Workflow Add Data Trigger Disable Enable Post Trigger
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesFormulaEngine.test.ts:196:5 › Collection event Add Data Trigger, Formula engine, determines that the trigger node single line text field variable is not equal to an equal constant, fails.

976 passed, 29 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@mytharcher mytharcher merged commit fb25042 into main May 29, 2024
8 checks passed
@mytharcher mytharcher deleted the T-4376 branch May 29, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant