Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing linkage rules configuration for submit action in edit form #4515

Merged
merged 1 commit into from
May 29, 2024

Conversation

katherinehhh
Copy link
Contributor

Description

Motivation

Key changes

  • Frontend
  • Backend

Test plan

Suggestions

Underlying risk

Showcase

Copy link

height bot commented May 29, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-4377" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@katherinehhh katherinehhh changed the title fix: update form submit action missing linkageRules setting fix: missing linkage rules configuration for submit action in edit form May 29, 2024

This comment has been minimized.

Copy link

Tests results for "E2E"

11 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoFormulaEngine.test.ts:380:5 › Collection event Add Data Trigger, determines that the trigger node single line text field variable is not equal to an unequal constant, passes.
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:30:7 › where grid card block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers › TableActionInitializers should add bulk update
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:388:9 › actions schema settings › update record › Assign field values
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/editLocalStorage.test.ts:15:7 › File manager › edit local storage title
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-custom-request/src/client/__e2e__/schemaSettings.test.ts:13:7 › custom request action › edit button

976 passed, 29 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@hongboji hongboji merged commit 6a9d39f into main May 29, 2024
9 checks passed
@hongboji hongboji deleted the T-4377 branch May 29, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants