Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l10n): i18n namespace of page title #4557

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix(l10n): i18n namespace of page title #4557

merged 2 commits into from
Jun 5, 2024

Conversation

2013xile
Copy link
Contributor

@2013xile 2013xile commented Jun 5, 2024

Description

Steps to reproduce

  1. Add a menu
  2. Use the localization plugin to translate the menu text

Expected behavior

  1. The menu text would be translated
  2. The page title would be translated

Actual behavior

  1. The menu text was translated ✅
  2. The page title was not translated ❌

Related issues

Reason

The i18n namespace of page titles is different from menus.

Solution

Use the same i18n namespace for page titles and menus.

This comment has been minimized.

Copy link

github-actions bot commented Jun 5, 2024

Tests results for "E2E"

3 failed
❌ [chromium] › core/client/src/modules/blocks/data-blocks/form/e2e/form-create/schemaSettings1.test.ts:277:7 › creation form block schema settings › save block template & using block template
❌ [chromium] › core/client/src/modules/blocks/data-blocks/table/e2e/schemaSettings1.test.ts:359:9 › table block schema settings › connect data blocks › should not lose the filtering function when dragging and connecting
❌ [chromium] › plugins/@nocobase/plugin-auth/src/client/e2e/auth.test.ts:21:7 › auth › register

13 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoFormulaEngine.test.ts:936:5 › Collection event add data trigger, determine the trigger node integer variable is not equal to the query node not equal integer variable, pass.
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:314:9 › table block schema settings › connect data blocks › should immediately show in the drop-down menu of Connect data blocks when adding a block for the first time
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers › TableActionInitializers should add bulk update
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/datetime/schemaInitializer.test.ts:86:7 › table column & table › configure columns
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-action-custom-request/src/client/__e2e__/schemaSettings.test.ts:13:7 › custom request action › edit button
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaInitailizer.test.ts:52:7 › configure fields › add association field should appends association
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-create/dragAndDrop.test.ts:12:5 › fields
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:30:7 › where grid card block can be added › popup
⚠️ [chromium] › core/client/src/modules/popup/__e2e__/schemaInitializer1.test.ts:220:7 › where to open a popup and what can be added to it › data picker
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers

972 passed, 29 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@2013xile 2013xile merged commit af1325f into main Jun 5, 2024
8 of 9 checks passed
@2013xile 2013xile deleted the fix/page-title-ns branch June 5, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant