Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: url support preview #4559

Merged
merged 8 commits into from
Jun 6, 2024
Merged

feat: url support preview #4559

merged 8 commits into from
Jun 6, 2024

Conversation

chenos
Copy link
Contributor

@chenos chenos commented Jun 5, 2024

Support for switching the URL field component to Preview for previewing the image represented by the URL.

20240606122725

@chenos chenos requested a review from zhangzhonghe June 5, 2024 02:31

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zhangzhonghe zhangzhonghe merged commit 22a8986 into main Jun 6, 2024
8 checks passed
@zhangzhonghe zhangzhonghe deleted the T-4469 branch June 6, 2024 06:11
Copy link

github-actions bot commented Jun 6, 2024

Tests results for "E2E"

9 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers › TableActionInitializers should add bulk update
⚠️ [chromium] › plugins/@nocobase/plugin-action-custom-request/src/client/__e2e__/schemaSettings.test.ts:13:7 › custom request action › edit button
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-calendar/src/client/__e2e__/schemaInitializer.test.ts:14:7 › where can be added › page
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoMathEngine.test.ts:375:5 › Collection event add data trigger, determines that the trigger node integer field variable is not equal to an unequal constant, passes.
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/belongsTo/schemaSettings2.test.ts:210:7 › form item & edit form › title field
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers

980 passed, 29 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

chareice pushed a commit that referenced this pull request Jun 7, 2024
* feat: url support preview

* feat: add settings for Input.Preview

* refactor: refactor CollectionField.tsx to use dynamic component

* Revert "refactor: refactor CollectionField.tsx to use dynamic component"

This reverts commit 37719eb.

* test: add e2e test

* refactor(e2e): extract template

---------

Co-authored-by: Zeke Zhang <958414905@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants