refactor: rewrite the UI of the code scanner. #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/presets/nocobase/package.json
# Conflicts: # packages/plugins/@nocobase/plugin-block-workbench/src/client/WorkbenchBlock.tsx
# Conflicts: # packages/presets/nocobase/package.json
# Conflicts: # packages/plugins/@nocobase/plugin-block-workbench/src/client/WorkbenchScanActionSchemaInitializerItem.tsx # packages/plugins/@nocobase/plugin-block-workbench/src/client/index.tsx
|
|
chenos
added a commit
that referenced
this pull request
Jun 30, 2024
* feat: workbench block * feat: mobilePage * fix: update WorkbenchAction * feat: support qrcode embed in markdown and scan in mobile * fix: fix markdown button be covered problem * fix: fix unit test error * fix: fix unit test errors * refactor: use react router in qrcode scanner * feat: markdown add loading * fix: fix blank content in print page * refactor: change plugin dependencies to devDependencies * feat: add some padding in markdown editor * chore: improve some code * feat: improve code * fix: add QRCodeScanner * fix: iconColor * fix: Improve code * feat: Improve code * fix: version * chore: improve some code * chore: improve some code * fix: i18n * refactor: refact the UI of code scanner * feat: add some locale * feat: add qrbox * feat: add image upload and fix qrbox * feat: fix full screen problem * fix: fix not full screen problem * fix: add some error handling * feat: add album locale --------- Co-authored-by: chenos <chenlinxh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rewrite UI of the code scanner
Motivation
Previously, the QR code scanner used the built-in UI of html5-qrcode, which provided a poor user experience. This rewrite focuses on optimizing the UI for mobile devices.
Key changes
The QR code scanner now defaults to using the rear camera and includes UI localization features.
Test plan
Suggestions
Underlying risk
Showcase
20240617-142651.mp4