Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-workflow): fix designable of assign fields in create/update node #4724

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mytharcher
Copy link
Contributor

Description

Fix designable of assign fields in create/update node.

Steps to reproduce

  1. Add an update node and configure some fields to assign values.
  2. Trigger the workflow.
  3. Review the node configuration of executed workflow.

Expected behavior

Assign values fields should not be designable after executed.

Actual behavior

Designable.

Related issues

None.

Reason

Designable logic.

Solution

Use nodeForm.disabled to calculate designable.

Copy link

Tests results for "E2E"

9 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › plugins/@nocobase/plugin-action-duplicate/src/client/__e2e__/schemaInitailizer.test.ts:13:7 › TableActionColumnInitializers & DetailsActionInitializers & ReadPrettyFormActionInitializers should add duplication action › duplication action in TableActionColumnInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaSettings.test.ts:26:7 › configure params in gantt block › set data scope in gantt block
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:65:9 › table block schema settings › enable drag and drop sorting › enable drag and drop sorting
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesMathEngine.test.ts:281:5 › Collection event add data trigger, Math engine, determines that the trigger node integer field variable is not equal to an unequal constant, passes.

986 passed, 30 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@mytharcher mytharcher merged commit bda976e into main Jun 21, 2024
8 checks passed
@mytharcher mytharcher deleted the fix/plugin-workflow-node-schema-designable branch June 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant