Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-workflow): add loading for adding node #4726

Merged
merged 3 commits into from
Jun 22, 2024
Merged

fix(plugin-workflow): add loading for adding node #4726

merged 3 commits into from
Jun 22, 2024

Conversation

mytharcher
Copy link
Contributor

Description

Add loading for adding node.

Steps to reproduce

Small possibility no reaction from server when adding node for a while, and quickly add another node, newly added node will be lost from the canvas but exist in data.

Expected behavior

No un-fully-linked node.

Actual behavior

Un-fully-linked node exists.

Related issues

None.

Reason

Need waiting for response from server.

Solution

Add loading status for button of adding node.

Copy link

height bot commented Jun 21, 2024

This pull request has been linked to 1 task:

  • T-4628 添加节点时,小概率情况当事务卡住时,导致的重复添加同一个节点后,会出现悬空的节点,无法在画布上显示,但影响流程运行 (unlink task)

💡Tip: Add "Close T-4628" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Copy link

Tests results for "E2E"

9 flaky ⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-create/lazyLoadAssociationFields.test.ts💯7 › association fields › should be possible to change the value of the association field normally
⚠️ [chromium] › core/client/src/modules/popup/__e2e__/schemaInitializer1.test.ts:135:7 › where to open a popup and what can be added to it › bulk edit
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-kanban/src/client/__e2e__/schemaSettings.test.ts:15:7 › configure setting › set the data scope
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:30:7 › where grid card block can be added › popup
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface

986 passed, 30 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@mytharcher mytharcher merged commit 1cba634 into main Jun 22, 2024
23 checks passed
@mytharcher mytharcher deleted the T-4628 branch June 22, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant