Skip to content

Commit

Permalink
fix(nc-gui): expanded form field menu placement issue
Browse files Browse the repository at this point in the history
  • Loading branch information
rameshmane7218 committed May 10, 2024
1 parent 06c3185 commit 00fbf9d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/nc-gui/components/smartsheet/header/Cell.vue
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ const onClick = (e: Event) => {
:placement="isExpandedForm ? 'bottomLeft' : 'bottomRight'"
overlay-class-name="nc-dropdown-edit-column"
>
<div v-if="isExpandedForm" @dblclick.stop class="max-h-[0px] max-w-[0px]">&nbsp;</div>
<div v-if="isExpandedForm" @dblclick.stop class="h-[1px]">&nbsp;</div>
<div v-else />

<template #overlay>
Expand Down
7 changes: 2 additions & 5 deletions packages/nc-gui/components/smartsheet/header/Menu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,8 @@ const filterOrGroupByThisField = (event: SmartsheetStoreEvents) => {
@click.stop="isOpen = !isOpen"
>
<div @dblclick.stop>
<GeneralIcon
v-if="!isExpandedForm"
icon="arrowDown"
class="text-grey h-full text-grey nc-ui-dt-dropdown cursor-pointer outline-0 mr-2"
/>
<div v-if="isExpandedForm" class="h-[1px]">&nbsp;</div>
<GeneralIcon v-else icon="arrowDown" class="text-grey h-full text-grey nc-ui-dt-dropdown cursor-pointer outline-0 mr-2" />
</div>
<template #overlay>
<NcMenu
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ const onClick = (e: Event) => {
:placement="isExpandedForm ? 'bottomLeft' : 'bottomRight'"
overlay-class-name="nc-dropdown-edit-column"
>
<div v-if="isExpandedForm" @dblclick.stop class="max-h-[0px] max-w-[0px]">&nbsp;</div>
<div v-if="isExpandedForm" @dblclick.stop class="h-[1px]">&nbsp;</div>
<div v-else />
<template #overlay>
<SmartsheetColumnEditOrAddProvider
Expand Down

0 comments on commit 00fbf9d

Please sign in to comment.