fix: invalid count issue

nocodb · Apr 17, 2024 · 048ea0c · 048ea0c
1 parent a1c01bd
commit 048ea0c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
@@ -61,9 +61,7 @@ const {
 
 const hiddenFields = ref<string[]>([])
 
-const isLocalMode = computed(
-  () => isPublic || !isUIAllowed('viewFieldEdit') || !isUIAllowed('viewFieldEdit') || isSharedBase.value,
-)
+const isLocalMode = computed(() => isPublic || !isUIAllowed('viewFieldEdit') || isSharedBase.value)
 
 const shouldShowField = (id: string) => {
   if (isLocalMode.value && hiddenFields.value.includes(id)) return false
@@ -92,7 +90,9 @@ watch(
 
 const numberOfHiddenFields = computed(() => {
   if (isLocalMode.value) {
-    return filteredFieldList.value?.filter((field) => !hiddenFields.value.includes(field.id) && !field.show)?.length
+    // slice is added to remove the first element ie column with name title as default value , without slice the count will always be one more than the exact count
+    return filteredFieldList.value?.slice(1).filter((field) => !hiddenFields.value.includes(field.id) && field.show === false)
+      ?.length
   } else {
     return filteredFieldList.value?.filter((field) => !field.show)?.length
   }

diff --git a/packages/nc-gui/composables/useViewColumns.ts b/packages/nc-gui/composables/useViewColumns.ts
@@ -146,7 +146,7 @@ const [useProvideViewColumns, useViewColumns] = useInjectionState(
       if (isLocalMode.value) {
         fields.value = fields.value?.map((field: Field) => ({
           ...field,
-          show: false,
+          show: !!field.isViewEssentialField,
         }))
         reloadData?.()
         return