refactor: use set to avoid duplicate

nocodb · Apr 2, 2024 · 0f9acb1 · 0f9acb1 · github-actions · Apr 2, 2024
1 parent 2dc59ef
commit 0f9acb1
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/packages/nocodb/src/models/Model.ts b/packages/nocodb/src/models/Model.ts
@@ -817,21 +817,24 @@ export default class Model implements TableType {
       }
     }
 
+    // use set to avoid duplicate
+    const relatedModelIds = new Set<string>();
+
     // clear all single query cache of related views
     for (const col of model.columns) {
       if (!isLinksOrLTAR(col)) continue;
       const colOptions = await col.getColOptions<
         LinkToAnotherRecordColumn | LinksColumn
       >();
-      if (colOptions.fk_related_model_id === model.id) {
-        await View.clearSingleQueryCache(
-          colOptions.fk_related_model_id,
-          null,
-          ncMeta,
-        );
-      }
+      relatedModelIds.add(colOptions?.fk_related_model_id);
     }
 
+    await Promise.all(
+      Array.from(relatedModelIds).map(async (modelId: string) => {
+        await View.clearSingleQueryCache(modelId, null, ncMeta);
+      }),
+    );
+
     return true;
   }