Skip to content

Commit

Permalink
fix(playwright): oss tests fix
Browse files Browse the repository at this point in the history
  • Loading branch information
DarkPhoenix2704 committed Mar 13, 2024
1 parent 3c53826 commit 463ee7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/playwright/pages/Dashboard/common/Topbar/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export class TopbarPage extends BasePage {
async getSharedBaseUrl({ role, enableSharedBase }: { role: string; enableSharedBase: boolean }) {
await this.clickShare();
await this.share.clickShareBase();
await this.share.switchBaseShareTab({ tab: 'public' });

if (enableSharedBase) await this.share.clickShareBasePublicAccess();

Expand All @@ -66,7 +67,6 @@ export class TopbarPage extends BasePage {
} else if (role === 'viewer' && !enableSharedBase) {
await this.share.clickShareBaseEditorAccess();
}
await this.share.switchBaseShareTab({ tab: 'public' });
await this.share.clickCopyLink();
await this.share.closeModal();
return await this.getClipboardText();
Expand Down

1 comment on commit 463ee7f

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR changes have been deployed. Please run the following command to verify:

docker run -d -p 8888:8080 nocodb/nocodb-timely:0.204.4-pr-7845-20240313-1522

Please sign in to comment.