Merge pull request #8542 from nocodb/nc-refactor/modules

refactor: merge core modules into single noco module

packages/nocodb/src/app.module.ts

@@ -5,34 +5,23 @@ import { ConfigModule } from '@nestjs/config';
 import { EventEmitterModule as NestJsEventEmitter } from '@nestjs/event-emitter';
 import { SentryModule } from '@ntegral/nestjs-sentry';
 import type { MiddlewareConsumer } from '@nestjs/common';
+import { NocoModule } from '~/modules/noco.module';
+import { AuthModule } from '~/modules/auth/auth.module';
 import { GlobalExceptionFilter } from '~/filters/global-exception/global-exception.filter';
 import { GlobalMiddleware } from '~/middlewares/global/global.middleware';
 import { GuiMiddleware } from '~/middlewares/gui/gui.middleware';
-import { DatasModule } from '~/modules/datas/datas.module';
 import { EventEmitterModule } from '~/modules/event-emitter/event-emitter.module';
-import { AuthService } from '~/services/auth.service';
-import { GlobalModule } from '~/modules/global/global.module';
-import { LocalStrategy } from '~/strategies/local.strategy';
-import { AuthTokenStrategy } from '~/strategies/authtoken.strategy/authtoken.strategy';
-import { BaseViewStrategy } from '~/strategies/base-view.strategy/base-view.strategy';
-import { MetasModule } from '~/modules/metas/metas.module';
 import { JobsModule } from '~/modules/jobs/jobs.module';
 
 import appConfig from '~/app.config';
 import { ExtractIdsMiddleware } from '~/middlewares/extract-ids/extract-ids.middleware';
 
-import { BasicStrategy } from '~/strategies/basic.strategy/basic.strategy';
-import { UsersModule } from '~/modules/users/users.module';
-import { AuthModule } from '~/modules/auth/auth.module';
 import { packageInfo } from '~/utils/packageVersion';
 
 export const ceModuleConfig = {
   imports: [
-    GlobalModule,
-    UsersModule,
     AuthModule,
-    MetasModule,
-    DatasModule,
+    NocoModule,
     EventEmitterModule,
     JobsModule,
     NestJsEventEmitter.forRoot(),
@@ -53,7 +42,6 @@ export const ceModuleConfig = {
       : []),
   ],
   providers: [
-    AuthService,
     {
       provide: APP_FILTER,
       useClass: GlobalExceptionFilter,
@@ -62,10 +50,6 @@ export const ceModuleConfig = {
       provide: APP_GUARD,
       useClass: ExtractIdsMiddleware,
     },
-    LocalStrategy,
-    AuthTokenStrategy,
-    BaseViewStrategy,
-    BasicStrategy,
   ],
 };
 

packages/nocodb/src/controllers/data-alias-export.controller.ts

@@ -3,7 +3,7 @@ import { Request, Response } from 'express';
 import * as XLSX from 'xlsx';
 import { GlobalGuard } from '~/guards/global/global.guard';
 import { DatasService } from '~/services/datas.service';
-import { extractCsvData, extractXlsxData } from '~/modules/datas/helpers';
+import { extractCsvData, extractXlsxData } from '~/helpers/dataHelpers';
 import { View } from '~/models';
 import { Acl } from '~/middlewares/extract-ids/extract-ids.middleware';
 import { DataApiLimiterGuard } from '~/guards/data-api-limiter.guard';

packages/nocodb/src/controllers/old-datas/old-datas.service.ts

@@ -1,6 +1,6 @@
 import { Injectable } from '@nestjs/common';
 import { nocoExecute } from 'nc-help';
-import type { OldPathParams } from '~/modules/datas/helpers';
+import type { OldPathParams } from '~/helpers/dataHelpers';
 import getAst from '~/helpers/getAst';
 import { NcError } from '~/helpers/catchError';
 import { Base, Model, Source, View } from '~/models';

packages/nocodb/src/controllers/public-datas-export.controller.ts

@@ -12,7 +12,7 @@ import { nocoExecute } from 'nc-help';
 import papaparse from 'papaparse';
 import { NcError } from '~/helpers/catchError';
 import getAst from '~/helpers/getAst';
-import { serializeCellValue } from '~/modules/datas/helpers';
+import { serializeCellValue } from '~/helpers/dataHelpers';
 import { PublicDatasExportService } from '~/services/public-datas-export.service';
 import NcConnectionMgrv2 from '~/utils/common/NcConnectionMgrv2';
 import { Column, Model, Source, View } from '~/models';

packages/nocodb/src/controllers/auth/auth.controller.ts → packages/nocodb/src/modules/auth/auth.controller.ts

@@ -232,11 +232,14 @@ export class AuthController {
   ): Promise<any> {
     try {
       res.send(
-        ejs.render((await import('./ui/auth/resetPassword')).default, {
-          ncPublicUrl: process.env.NC_PUBLIC_URL || '',
-          token: JSON.stringify(tokenId),
-          baseUrl: `/`,
-        }),
+        ejs.render(
+          (await import('~/modules/auth/ui/auth/resetPassword')).default,
+          {
+            ncPublicUrl: process.env.NC_PUBLIC_URL || '',
+            token: JSON.stringify(tokenId),
+            baseUrl: `/`,
+          },
+        ),
       );
     } catch (e) {
       return res.status(400).json({ msg: e.message });

packages/nocodb/src/modules/auth/auth.module.ts

@@ -1,16 +1,31 @@
-import { forwardRef, Module } from '@nestjs/common';
+import { Module } from '@nestjs/common';
 import { PassportModule } from '@nestjs/passport';
+
+import { NocoModule } from '~/modules/noco.module';
+
+import { BasicStrategy } from '~/strategies/basic.strategy/basic.strategy';
+import { LocalStrategy } from '~/strategies/local.strategy';
+import { AuthTokenStrategy } from '~/strategies/authtoken.strategy/authtoken.strategy';
+import { BaseViewStrategy } from '~/strategies/base-view.strategy/base-view.strategy';
 import { GoogleStrategyProvider } from '~/strategies/google.strategy/google.strategy';
-import { UsersService } from '~/services/users/users.service';
-import { AuthController } from '~/controllers/auth/auth.controller';
-import { MetasModule } from '~/modules/metas/metas.module';
+import { AuthService } from '~/modules/auth/auth.service';
+import { AuthController } from '~/modules/auth/auth.controller';
 
-@Module({
-  imports: [PassportModule, forwardRef(() => MetasModule)],
+export const authModuleMetadata = {
+  imports: [PassportModule, NocoModule],
   controllers: [
     ...(process.env.NC_WORKER_CONTAINER !== 'true' ? [AuthController] : []),
   ],
-  providers: [UsersService, GoogleStrategyProvider],
-  exports: [UsersService],
-})
+  providers: [
+    AuthService,
+    LocalStrategy,
+    AuthTokenStrategy,
+    BaseViewStrategy,
+    BasicStrategy,
+    GoogleStrategyProvider,
+  ],
+  exports: [],
+};
+
+@Module(authModuleMetadata)
 export class AuthModule {}

packages/nocodb/src/modules/jobs/jobs.module.ts

@@ -1,5 +1,6 @@
-import { Module } from '@nestjs/common';
+import { forwardRef, Module } from '@nestjs/common';
 import { BullModule } from '@nestjs/bull';
+import { NocoModule } from '~/modules/noco.module';
 
 // Jobs
 import { ExportService } from '~/modules/jobs/jobs/export-import/export.service';
@@ -29,13 +30,10 @@ import { JobsService as FallbackJobsService } from '~/modules/jobs/fallback/jobs
 import { QueueService as FallbackQueueService } from '~/modules/jobs/fallback/fallback-queue.service';
 import { JobsEventService as FallbackJobsEventService } from '~/modules/jobs/fallback/jobs-event.service';
 import { JOBS_QUEUE } from '~/interface/Jobs';
-import { MetasModule } from '~/modules/metas/metas.module';
-import { DatasModule } from '~/modules/datas/datas.module';
 
 export const JobsModuleMetadata = {
   imports: [
-    DatasModule,
-    MetasModule,
+    forwardRef(() => NocoModule),
     ...(process.env.NC_REDIS_JOB_URL
       ? [
           BullModule.forRoot({

packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts

@@ -8,7 +8,7 @@ import type { BaseModelSqlv2 } from '~/db/BaseModelSqlv2';
 import type { View } from '~/models';
 import { Base, Hook, Model, Source } from '~/models';
 import NcConnectionMgrv2 from '~/utils/common/NcConnectionMgrv2';
-import { getViewAndModelByAliasOrId } from '~/modules/datas/helpers';
+import { getViewAndModelByAliasOrId } from '~/helpers/dataHelpers';
 import { clearPrefix, generateBaseIdMap } from '~/helpers/exportImportHelpers';
 import NcPluginMgrv2 from '~/helpers/NcPluginMgrv2';
 import { NcError } from '~/helpers/catchError';