Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIDT-improvements] Rating field error on inserting record #2036

Closed
dstala opened this issue May 13, 2022 · 2 comments
Closed

[UIDT-improvements] Rating field error on inserting record #2036

dstala opened this issue May 13, 2022 · 2 comments
Assignees
Labels
🏗️ Type: In Develop Branch Ongoing issues on develop branch

Comments

@dstala
Copy link
Member

dstala commented May 13, 2022

Node: v14.18.0
Arch: arm64
Platform: darwin
Docker: false
Database: sqlite3
ProjectOnRootDB: true
RootDB: sqlite3
PackageVersion: 0.90.11

  • empty table, add rating field
  • insert record

Screenshot 2022-05-13 at 7 02 37 PM

@dstala dstala added the 🏗️ Type: In Develop Branch Ongoing issues on develop branch label May 13, 2022
@dstala
Copy link
Member Author

dstala commented May 13, 2022

Similar error observed with Checkbox field as well

@pranavxc pranavxc added the 🏗️ Status: In Resolution Work in Progress label May 14, 2022
pranavxc added a commit that referenced this issue May 14, 2022
@pranavxc pranavxc assigned dstala and unassigned pranavxc May 14, 2022
@dstala dstala added Status: Fixed and removed 🏗️ Status: In Resolution Work in Progress labels May 14, 2022
pranavxc added a commit that referenced this issue May 15, 2022
re #2036

Signed-off-by: Pranav C <pranavxc@gmail.com>
pranavxc added a commit that referenced this issue May 15, 2022
re #2036

Signed-off-by: Pranav C <pranavxc@gmail.com>
pranavxc added a commit that referenced this issue May 16, 2022
re #2036

Signed-off-by: Pranav C <pranavxc@gmail.com>
pranavxc added a commit that referenced this issue May 16, 2022
* wip: rating cell ui implementation

Signed-off-by: Pranav C <pranavxc@gmail.com>

* wip: migration for meta column data field

Signed-off-by: Pranav C <pranavxc@gmail.com>

* wip: rating column options

Signed-off-by: Pranav C <pranavxc@gmail.com>

* feat: rating cell creation and mapping metadata

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor:  change default type to int for rating

Signed-off-by: Pranav C <pranavxc@gmail.com>

* feat: add email cell

Signed-off-by: Pranav C <pranavxc@gmail.com>

* feat: accept invalid values for columns if validation disabled

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor: remove additional options

Signed-off-by: Pranav C <pranavxc@gmail.com>

* feat: checkbox customization

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor: move validate checkbox to advance option

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor: add tick icon in checkbox

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor: start rating max value from 1

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor: minor ui corrections

Signed-off-by: Pranav C <pranavxc@gmail.com>

* fix: load rating component in gallery view

Signed-off-by: Pranav C <pranavxc@gmail.com>

* fix: use default icon and color if meta missing(checkbox and rating)

re #2036

Signed-off-by: Pranav C <pranavxc@gmail.com>

* fix: cache column with parsed metadata

re #2038

Signed-off-by: Pranav C <pranavxc@gmail.com>

* fix: convert old rating column to number type

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor: migration filename correction

Signed-off-by: Pranav C <pranavxc@gmail.com>

* refactor: component name

Signed-off-by: Pranav C <pranavxc@gmail.com>
@github-actions
Copy link
Contributor

Fixed in v0.91.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ Type: In Develop Branch Ongoing issues on develop branch
Projects
None yet
Development

No branches or pull requests

2 participants