Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download CSV error with specific non-english table/column name #2286

Closed
Entmatix opened this issue Jun 8, 2022 · 11 comments
Closed

Download CSV error with specific non-english table/column name #2286

Entmatix opened this issue Jun 8, 2022 · 11 comments
Assignees
Labels
Status: Reproducible Able to reproduce the issue based on the reporters' guideline. 🐛 Type: Bug Something is broken or incorrect unexpectedly.

Comments

@Entmatix
Copy link

Entmatix commented Jun 8, 2022

NocoDB used as docker : true
NocoDB version : v0.91.7
Database used in NC_DB URL  : pg
Project was created  by clicking : New Project
Database on which spreadsheet is created : pg
OS on which NocoDB is running : debian 11
Node.js version if running as node : v14.18.0
Database version : 14.3-1.pgdg110+1

Steps To Reproduce

  1. Go to any table.
  2. Open greed view.
  3. Click More -> Download as CSV.
  4. See error "Request failed with status code 400".

Expected Behavior

Get CSV file for current table.

Screenshots

...

Additinal information

In log I see this when try to download csv.

nocodb-nocodb-1   | l :: TypeError [ERR_INVALID_CHAR]: Invalid character in header content ["Content-Disposition"]
nocodb-nocodb-1   |     at ServerResponse.setHeader (_http_outgoing.js:533:3)
nocodb-nocodb-1   |     at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:776:10)
nocodb-nocodb-1   |     at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:779:12)
nocodb-nocodb-1   |     at l (/usr/src/app/docker/main.js:2:1225710)
nocodb-nocodb-1   |     at processTicksAndRejections (internal/process/task_queues.js:97:5)
nocodb-nocodb-1   |     at async /usr/src/app/docker/main.js:2:35786 {
nocodb-nocodb-1   |   code: 'ERR_INVALID_CHAR'
nocodb-nocodb-1   | }

If applicable, add screenshots to help explain your problem.

Join our discord : https://discord.gg/5RgZmkW for realtime help.

@dstala dstala added Status: Reproducible Able to reproduce the issue based on the reporters' guideline. 🐛 Type: Bug Something is broken or incorrect unexpectedly. labels Jun 8, 2022
@Entmatix
Copy link
Author

Entmatix commented Jun 8, 2022

That's wrong information above. The app is dockerized, arch amd64. Also it's not table name, it's project name. Tables names are different. And please, remove the name. I haven't agreed to publish this information.

@dstala
Copy link
Member

dstala commented Jun 8, 2022

That's wrong information above. The app is dockerized, arch amd64. Also it's not table name, it's project name. Tables names are different. And please, remove the name. I haven't agreed to publish this information.

@Entmatix , was just informing dev team about an easy way to identify error. I have deleted comment as per your request. If table name is confidential, I would recommend striking off encoded URI in your log.

@dstala
Copy link
Member

dstala commented Jun 8, 2022

@Entmatix , removed encoded URI from your log

@Entmatix
Copy link
Author

Entmatix commented Jun 8, 2022

@Entmatix , removed encoded URI from your log

Thank you.

@okaeiz
Copy link

okaeiz commented Jun 8, 2022

I have the same issue. I cannot download tables as a csv file.

@dstala
Copy link
Member

dstala commented Jun 8, 2022

issue reproducible & observed with a specific set of characters (current observations, often non-english) in use in either table/ column name. we will explore a workaround for such instances.

@dstala dstala changed the title "Request failed with status code 400" when trying to download csv Download CSV error with specific non-english table/ column name Jun 8, 2022
@o1lab o1lab changed the title Download CSV error with specific non-english table/ column name Download CSV error with specific non-english table/column name Jun 8, 2022
@Entmatix
Copy link
Author

Entmatix commented Jun 8, 2022

@dstala, I'd be happy to participate in testing when update comes to docker container.

@o1lab
Copy link
Member

o1lab commented Jun 8, 2022

When we make a PR - there will be an automatic test that gets published. You can test that - appreciate your help :)

@okaeiz
Copy link

okaeiz commented Jun 8, 2022

So currently we cannot have ANY export of our database at all? 😨

@okaeiz
Copy link

okaeiz commented Jun 9, 2022

We have checked the image shared here.
Exporting csv was okay but now when we try to import the same csv, it raises an error.

Untitled

@github-actions
Copy link
Contributor

Fixed in v0.91.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reproducible Able to reproduce the issue based on the reporters' guideline. 🐛 Type: Bug Something is broken or incorrect unexpectedly.
Projects
None yet
Development

No branches or pull requests

5 participants