Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API JSON output limited to 1000 #2306

Closed
fishnux opened this issue Jun 9, 2022 · 6 comments
Closed

REST API JSON output limited to 1000 #2306

fishnux opened this issue Jun 9, 2022 · 6 comments
Assignees
Labels
Status: Reproducible Able to reproduce the issue based on the reporters' guideline. ✨ Type: Enhancement Some new changes adding on the existing functionality to make better.

Comments

@fishnux
Copy link

fishnux commented Jun 9, 2022

NocoDB used as docker : true 
NocoDB version : 
Database used in NC_DB URL  : mysql 
Project was created  by clicking : New Project by connecting to external database
Database on which spreadsheet is created : (unsure)
OS on which NocoDB is running : Linux
Node.js version if running as node : As Docker
Database version : Unsure

Steps To Reproduce

Do a Get All REST API with limit 10000 offset 0 on table that has more than 1000 rows

Expected Behavior

Returns more than 1000 rows (assuming table has about 4000 rows)

Defined ENV variables:

DB_QUERY_LIMIT_MAX = 10000
DB_QUERY_LIMIT_DEFAULT = 100
@o1lab
Copy link
Member

o1lab commented Jun 9, 2022

Max is 1000.

@wingkwong
Copy link
Member

@fishnux Given the ENV variables you've set, how many records you've got? 100?

@fishnux
Copy link
Author

fishnux commented Jun 10, 2022

@fishnux Given the ENV variables you've set, how many records you've got? 100?

I get exactly 1000 elements in the JSON, in the database I have about 4000 rows. The "PageInfo" also seemed to indicate all 4000 rows were returned (despite only outputting 1000 elements), though I don't remember for sure

@wingkwong
Copy link
Member

Can you show us pageInfo in your returned json?

@fishnux
Copy link
Author

fishnux commented Jun 10, 2022

Can you show us pageInfo in your returned json?

{
  "totalRows": 4050,
  "page": 1,
  "pageSize": "10000",
  "isFirstPage": true,
  "isLastPage": true
}

@wingkwong wingkwong self-assigned this Jun 10, 2022
@wingkwong wingkwong added Status: Reproducible Able to reproduce the issue based on the reporters' guideline. ✨ Type: Enhancement Some new changes adding on the existing functionality to make better. 🏗️ Status: In Resolution Work in Progress labels Jun 10, 2022
@wingkwong wingkwong added this to the Next Release : v0.91.x milestone Jun 11, 2022
@github-actions
Copy link
Contributor

Fixed in v0.91.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reproducible Able to reproduce the issue based on the reporters' guideline. ✨ Type: Enhancement Some new changes adding on the existing functionality to make better.
Projects
None yet
Development

No branches or pull requests

3 participants