Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: [Nest] ERROR [i] Missing refresh token #5817

Closed
1 task done
GiantCrocodile opened this issue Jun 5, 2023 · 4 comments
Closed
1 task done

馃悰 Bug: [Nest] ERROR [i] Missing refresh token #5817

GiantCrocodile opened this issue Jun 5, 2023 · 4 comments
Assignees

Comments

@GiantCrocodile
Copy link

GiantCrocodile commented Jun 5, 2023

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Steps to reproduce ?

After updating from previous version to latest version, I get this error in the docker logs:

[Nest] 1 - 06/05/2023, 4:43:37 PM ERROR [i] Missing refresh token
Error: Missing refresh token
at t.NcError.badRequest (/app/code/node_modules/nocodb/dist/bundle.js:1:649372)
at k.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:1245325)
at j.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:174280)
at /app/code/node_modules/@nestjs/core/router/router-execution-context.js:38:29
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async /app/code/node_modules/@nestjs/core/router/router-execution-context.js:46:28
at async /app/code/node_modules/@nestjs/core/router/router-proxy.js:9:17

Just open the logon page and check the logging of the docker container. Issue didn't occur in previous versions of nocodb.

Desired Behavior

No error thrown

Project Details

Node: v18.12.1
Arch: x64
Platform: linux
Docker: true
RootDB: pg
PackageVersion: 0.108.1

Attachments

No response

@GiantCrocodile GiantCrocodile changed the title 馃悰 Bug: 馃悰 Bug: [Nest] ERROR [i] Missing refresh token Jun 5, 2023
@pranavxc
Copy link
Member

pranavxc commented Jun 6, 2023

There were some issues with the refresh token earlier we fixed it recently. It's expected to show that error if a refresh token is missing in the request. Instead of throwing the error, we will handle it in a better way. Is it happening frequently and blocking the app from using?

@pranavxc pranavxc assigned pranavxc and unassigned o1lab Jun 6, 2023
@GiantCrocodile
Copy link
Author

I can use the app (login works). The error just occurs every time I open the logon page. I don't see an impact from it.

pranavxc added a commit that referenced this issue Jun 7, 2023
re #5817

Signed-off-by: Pranav C <pranavxc@gmail.com>
@GiantCrocodile
Copy link
Author

GiantCrocodile commented Jun 16, 2023

Doesn't seem to be completely fixed @pranavxc. After updating to 0.109.1, I get this:

Jun 14 12:20:59 [Nest] 1 - 06/14/2023, 10:20:59 AM ERROR [i] Missing refresh token
Jun 14 12:20:59 Error: Missing refresh token
Jun 14 12:20:59 at /app/code/node_modules/@nestjs/core/router/router-execution-context.js:38:29
Jun 14 12:20:59 at async /app/code/node_modules/@nestjs/core/router/router-execution-context.js:46:28
Jun 14 12:20:59 at async /app/code/node_modules/@nestjs/core/router/router-proxy.js:9:17
Jun 14 12:20:59 at j.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:174433)
Jun 14 12:20:59 at k.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:1246586)
Jun 14 12:20:59 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Jun 14 12:20:59 at t.NcError.badRequest (/app/code/node_modules/nocodb/dist/bundle.js:1:649568)
Jun 14 17:45:01 [Nest] 1 - 06/14/2023, 3:45:01 PM ERROR [i] Missing refresh token
Jun 14 17:45:01 Error: Missing refresh token
Jun 14 17:45:01 at /app/code/node_modules/@nestjs/core/router/router-execution-context.js:38:29
Jun 14 17:45:01 at async /app/code/node_modules/@nestjs/core/router/router-execution-context.js:46:28
Jun 14 17:45:01 at async /app/code/node_modules/@nestjs/core/router/router-proxy.js:9:17
Jun 14 17:45:01 at j.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:174433)
Jun 14 17:45:01 at k.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:1246586)
Jun 14 17:45:01 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Jun 14 17:45:01 at t.NcError.badRequest (/app/code/node_modules/nocodb/dist/bundle.js:1:649568)
Jun 17 00:08:07 [Nest] 1 - 06/16/2023, 10:08:07 PM ERROR [i] Missing refresh token
Jun 17 00:08:07 Error: Missing refresh token
Jun 17 00:08:07 at /app/code/node_modules/@nestjs/core/router/router-execution-context.js:38:29
Jun 17 00:08:07 at async /app/code/node_modules/@nestjs/core/router/router-execution-context.js:46:28
Jun 17 00:08:07 at async /app/code/node_modules/@nestjs/core/router/router-proxy.js:9:17
Jun 17 00:08:07 at j.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:174433)
Jun 17 00:08:07 at k.refreshToken (/app/code/node_modules/nocodb/dist/bundle.js:1:1246586)
Jun 17 00:08:07 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Jun 17 00:08:07 at t.NcError.badRequest (/app/code/node_modules/nocodb/dist/bundle.js:1:649568)
Jun 17 00:08:22 [Nest] 1 - 06/16/2023, 10:08:22 PM ERROR [i] Invalid credentials
Jun 17 00:08:22 Error: Invalid credentials
Jun 17 00:08:22 at m.validate (/app/code/node_modules/nocodb/dist/bundle.js:1:1266489)
Jun 17 00:08:22 at t.NcError.badRequest (/app/code/node_modules/nocodb/dist/bundle.js:1:649568)

@dstala
Copy link
Member

dstala commented Aug 31, 2023

@GiantCrocodile Try v0.111.0; if you are still able to reproduce this issue, reopen. Thanks!

@dstala dstala closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants