Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Image display issue #7851

Closed
1 task done
chrisLusty opened this issue Mar 13, 2024 · 0 comments
Closed
1 task done

🐛 Bug: Image display issue #7851

chrisLusty opened this issue Mar 13, 2024 · 0 comments
Assignees
@rameshmane7218
Milestone
Q1

Comments

@chrisLusty
Copy link

Please confirm if bug report does NOT exist already ?

  • I confirm there is no existing issue for this

Steps to reproduce ?

  • Create a table where the records (rows) include an "Attachment" field, and populate the attachments with images (preferably of varying aspect ratios, but simple square images will do)
  • Create a gallery view for the table and assign the attachment images as the "cover image" for the gallery
  • Observe that, since all cover images are scaled to fit 100% width of their gallery "cards", images with a height:width aspect ratio larger than the predetermined aspect ratio of the "cover image" display box (which is approx approx 0.8:1) are undesirably cropped
  • A good example of this problem would be a gallery view of book jacket artworks, which traditionally have a substantially portrait aspect ratio, so are currently zoomed/cropped in display so as to make many title/author details unreadable

Desired Behavior

  • "Cover images" in gallery view should display the whole picture assigned to be view, regardless of original image aspect ratio, without cropping the image
  • For images with a heigh:width aspect ratio greater than the approx 0.8:1 aspect ratio of the display box, this would mean fitting the content based on a 100% height fit, instead of a 100% width fit
  • This issue appears to have previously been address with a perfectly workable solution (based on the screenshots shown) in fix fix(nc-gui): gallery cover image is clipped #4137 - however this fix does not seem to be present in recent versions of nocod

Project Details

Node: v18.17.1
Arch: x64
Platform: linux
Docker: true
RootDB: sqlite3
PackageVersion: 0.202.5

Attachments

No response
@o1lab o1lab changed the title 🐛 Bug: 🐛 Bug: Image display issue Mar 13, 2024
o1lab pushed a commit that referenced this issue Mar 14, 2024
@rameshmane7218
fix(nc-gui): gallery image display issue /issues/7851
c7f8ae8
@rameshmane7218 rameshmane7218 added this to the Q1 milestone Mar 14, 2024
@rameshmane7218 rameshmane7218 mentioned this issue Mar 14, 2024
Merged
7 tasks
o1lab pushed a commit that referenced this issue Mar 14, 2024
@rameshmane7218
fix(nc-gui): gallery image display issue /issues/7851
7950b77
o1lab pushed a commit that referenced this issue Mar 14, 2024
@rameshmane7218
fix(nc-gui): gallery image display issue /issues/7851
0b26966
o1lab pushed a commit that referenced this issue Mar 14, 2024
@rameshmane7218
fix(nc-gui): gallery image display issue /issues/7851
e79ad36
o1lab pushed a commit that referenced this issue Mar 14, 2024
@rameshmane7218
fix(nc-gui): gallery image display issue /issues/7851
42b540e
@dstala dstala closed this as completed Mar 14, 2024
dstala pushed a commit that referenced this issue Mar 14, 2024
@rameshmane7218
Nc feat/survey form v2 (#7843)
2cd0a1c 
* fix(nc-gui): survey form v2 setup

* fix(nc-gui): survey form ui updated

* fix(nc-gui): survery form ui changes for oss

* chore(nc-gui): lint

* chore(nc-gui): lint

* chore(nc-gui): revert unrelated changes

* test(nc-gui): update pw test of survey form

* fix(nc-gui): update survey form according to new design

* fix(nc-gui): add survey form slide animation

* fix(nc-gui): hide survey form pagination in first slide

* fix(nc-gui): optimize shared form for mobile screen

* chore(nc-gui): lint

* fix(nc-gui): pw test fail issue

* fix(nc-gui): some of the pr review changes

* fix(nc-gui): add placeholder for datetime related fields

* fix(nc-gui): allow upload same file next time

* fix(nc-gui): gallery image display issue /issues/7851

* chore(nc-gui): lint

* fix(nc-gui): survey form ui changes for oss

* fix(nc-gui): use i18n for survey form

* fix(nc-gui): use keydown space for date, datetime fields to open modal in survey form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rameshmane7218 rameshmane7218

Labels
None yet
Projects
🚀 NocoDB: Issue Board
Status: ✅ Closed
Milestone
Q1
Development

No branches or pull requests
2 participants
@chrisLusty @rameshmane7218