🐛 Bug: Metadata sync from MySQL ignores enum changes

[taeemo]

Please confirm if bug report does NOT exist already ?

• I confirm there is no existing issue for this

Steps to reproduce ?

• Create a MySQL2 datasource and create the initial database
• Edit the enum options in a specific table (e.g., add/remove options)
• Sync metadata
• At this point Noco will not detect any change.
• Side note: even forcing another change at MySQL level such as adding a new fake temporary column, still won't reflect the enum changes. Renaming the column seems to trigger the detection of right enums as well, but that's not an option in production

Desired Behavior

• The changes in the enum options should be detected
• The changes to the enum should be reflected in the table

Project Details

Node: v20.11.1
Arch: x64
Platform: linux
Docker: true
RootDB: mysql2
PackageVersion: 0.207.0

Attachments

No response

[taeemo]

So, it seems that the way we check the diff is not complete?
Here https://github.com/nocodb/nocodb/blob/develop/packages/nocodb/src/services/meta-diffs.service.ts#L244, we're checking just the type of the column. But in our case it's the same, enum, but different available options.

Apologies for the very crude/potentially wrong fix, but it seems that if we replace this condition

 if (oldCol.dt !== column.dt) {

with something like:

if (oldCol.dt !== column.dt ||
          oldCol.dt == 'enum' && oldCol.dtxp != column.dtxp
        ) {

It seems to fix the issue, and detect the change properly and is applied as expected.

Is this the right fix? Should I to submit a PR for this?