Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support Airtable import even mapped to a different port #2134

Merged
merged 2 commits into from May 26, 2022

Conversation

pranavxc
Copy link
Member

Change Summary

In the existing release it Airtable import will fail in docker if mapped to a port other than 8080.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Screenshot 2022-05-24 at 11 11 12 AM

re #2127

re #2127

Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc changed the title fix: Support airtable import if mapped to a different port fix: Support Airtable import even mapped to a different port May 24, 2022
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavxc Since PR Release failed, I triggered nightly build on f99ad57.

I got Error: connect ECONNREFUSED 127.0.0.1:80.

image

Here's the command I used. Not sure if I missed some env var or not.

docker run -d --name nocodb-pr2134 \
-p 7777:8080 \
-e NC_BASEURL_INTERNAL=7777 \
nocodb/nocodb-timely:0.91.0-20220524-1028

@pranavxc
Copy link
Member Author

pranavxc commented May 24, 2022

@pranavxc Since PR Release failed, I triggered nightly build on f99ad57.

I got Error: connect ECONNREFUSED 127.0.0.1:80.

image

Here's the command I used. Not sure if I missed some env var or not.

docker run -d --name nocodb-pr2134 \
-p 7777:8080 \
-e NC_BASEURL_INTERNAL=7777 \
nocodb/nocodb-timely:0.91.0-20220524-1028

In the case of docker, you can ignore the NC_BASEURL_INTERNAL since it will populate based on PORT. If you are providing it need to be a full URL like http://localhost:8080.

Within docker port 7777 is not available so the value should be http://localhost:8080 unless you are changing the PORT env value.

Try the following

docker run -d --name nocodb-pr2134 \
-p 7777:8080 \
nocodb/nocodb-timely:0.91.0-20220524-1028

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes. I misread it. Verified using your command.

@wingkwong wingkwong added this to the Next Release v0.91+ milestone May 25, 2022
@pranavxc pranavxc merged commit b8bdc7b into develop May 26, 2022
@pranavxc pranavxc deleted the fix/2127-docker-at-import branch May 26, 2022 05:38
dstala pushed a commit that referenced this pull request Jun 20, 2022
* fix: set default baseurl in docker and make it configurable

re #2127

Signed-off-by: Pranav C <pranavxc@gmail.com>

* chore: update documentation

Signed-off-by: Pranav C <pranavxc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants