Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/gui v2 #2810

Merged
merged 408 commits into from Jul 25, 2022
Merged

Refactor/gui v2 #2810

merged 408 commits into from Jul 25, 2022

Conversation

pranavxc
Copy link
Member

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

bcakmakoglu and others added 30 commits July 18, 2022 11:27
@bcakmakoglu @pranavxc
feat(gui-v2): use correct brand colors
cb7f284 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
chore(gui-v2): lessen shadow
60caf95 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
chore(gui-v2): add gap to social icons
973bce6 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
feat(gui-v2): add navigation to sidebar
8e195fb 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
chore(gui-v2): update share component styles
3528ba7 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
chore(gui-v2): add todo message
30e4de7 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
fix(gui-v2): overflow of main container
e3f1938 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
feat(gui-v2): update grid styles
1200500 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
feat(gui-v2,testing): use 5 col grid for grid view
98dd704 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@pranavxc
feat(gui-v2): add header cell with icon
de91373 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): add virtual header cell with icon
c2086f6 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): gallery view
2156097 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
wip(gui-v2): form view
767b414 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): add fields show/hide option
eee50fd 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
wip(gui-v2): filter and sort
033b097 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
wip(gui-v2): filter, sort integration with grid view
667f42d 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): filter, sort integration with grid view
d349c12 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): show all/hide all integration, reload data after change
f385f3a 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor(gui-v2): code cleanup
628f1a5 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@bcakmakoglu @pranavxc
feat(gui-v2): add dark mode to state and some styles
f149e37 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
feat(gui-v2): add sidebar switcher to header
f8ffc5b 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
revert(gui-v2): remove duplicating results
aa8e53b 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
feat(gui-v2,testing): add vitest and a simple component test
5d19d64 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
feat(gui-v2,test): add tests for sponsors translations
a7ce628 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu @pranavxc
chore(gui-v2,test): install i18n as plugin instead of mocking
ee28ec1 
Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
@pranavxc
feat(gui-v2): Show fields based on selected fields in fields menu
ecf5740 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): hide/show system fields
a46ac8c 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor(gui-v2): linting
eb18e31 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@wingkwong @pranavxc
chore: include viewIcon from v1
2c31d85
@wingkwong @pranavxc
refactor(gui-v2): add duration helper
19e6e69
wingkwong
wingkwong reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • lots of duplicate images. e.g. oracle.jpeg, oracle.png, oracle.png.jpg.
  • Dummy images innc-gui-v2/assets/img/abcd/ ?

packages/nc-gui-v2/assets/img/temp/251.json Outdated Show resolved Hide resolved
wingkwong
wingkwong approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments

pranavxc and others added 24 commits July 25, 2022 11:15
@pranavxc
wip(gui-v2): Basic tree view
6223312 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): add sortable
a82f163 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): context menu, table list reload, css corrections
78bdd3a 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): table delete
9ace314 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
wip(gui-v2): table rename
70755b8 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): table rename and minor improvements
5d37bb9 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
feat(gui-v2): update tab state on table rename
b7ce972 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor(gui-v2): table rename modal improvements
0f30974 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor(gui-v2): add table rename validation
c58e09e 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@dstala @pranavxc
fix: i18n corrections
933da78 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@pranavxc
fix: issue with sortable
d497668 
re #2820

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
chore(gui-v2): package-lock.json
9677c54 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
chore(gui-v2): cleanup files
3ec47bc 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@bcakmakoglu
refactor(gui-v2): cleanup template editor component
e4077cd 
# What's changed?

* fix types
* change arrow fns to regular functions to avoid ordering issues
* move templateColumns to utils file
@pranavxc
refactor(gui-v2): remove unused imports
b588e32 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@bcakmakoglu
refactor(gui-v2): cleanup project create utils
13c35c4 
# What's changed?

* move form type to utils file
* move ClientType enum to enums file
* use ClientType enum where appropriate
* add default host (localhost)
* lint files
@pranavxc
Merge pull request #2830 from nocodb/feat/nav-drawer-cleanup
0e19216 
refactor(gui-v2): cleanup project create utils
@wingkwong
Merge pull request #2828 from nocodb/feat/gui-v2-templates-fixed
c4efe2b 
refactor(gui-v2): cleanup template editor component
@pranavxc
Merge pull request #2827 from nocodb/refactor/gui-v2-cleanup
8e87786 
chore(gui-v2): cleanup files
@wingkwong
Merge pull request #2750 from nocodb/feat/gui-v2-templates
0d110ec 
feat(gui-v2): templates
@pranavxc
Merge pull request #2794 from nocodb/feat/nav-drawer
0c7e07a 
Feat/nav drawer
@bcakmakoglu
chore(gui-v2): fix eslint issues
6b447ce 
# What's changed?

* transform some components to script setup
* fix linting issues
@pranavxc
Merge pull request #2831 from nocodb/chore/fix-lint-issues
13c4539 
chore(gui-v2): fix eslint issues
@wingkwong
fix(gui-v2): ClientType & ProjectCreateForm path
0cbed32
@pranavxc pranavxc merged commit a481088 into develop Jul 25, 2022
@bcakmakoglu bcakmakoglu deleted the refactor/gui-v2 branch August 1, 2022 09:38
@bcakmakoglu bcakmakoglu restored the refactor/gui-v2 branch August 1, 2022 09:38
@pranavxc pranavxc deleted the refactor/gui-v2 branch August 18, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong approved these changes

@bcakmakoglu bcakmakoglu Awaiting requested review from bcakmakoglu

@dstala dstala Awaiting requested review from dstala

@mertmit mertmit Awaiting requested review from mertmit

@mustafapc19 mustafapc19 Awaiting requested review from mustafapc19

@o1lab o1lab Awaiting requested review from o1lab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pranavxc @wingkwong @bcakmakoglu @o1lab @dstala @mustafapc19