Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docs for playwright #4476

Merged
merged 7 commits into from Nov 25, 2022
Merged

Added docs for playwright #4476

merged 7 commits into from Nov 25, 2022

Conversation

mustafapc19
Copy link
Contributor

@mustafapc19 mustafapc19 commented Nov 23, 2022 •
edited

Ref: #4277

  • Added docs for playwright
  • Removed docs for cypress
  • Renamed Testing sub tub in Engineering section, to Unit testing, since it only has unit test docs

image

@mustafapc19 mustafapc19 marked this pull request as ready for review November 23, 2022 12:04
wingkwong
wingkwong reviewed Nov 23, 2022
View reviewed changes
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we no longer need nocodb/tests/playwright/README.md as I can see the documentation shows more details or we can just point the link to the documentation in README.md. Besides, we don't need to update both if there are changes.

packages/noco-docs/content/en/engineering/playwright.md Outdated Show resolved Hide resolved
packages/noco-docs/content/en/engineering/playwright.md Outdated Show resolved Hide resolved
@mustafapc19 mustafapc19 merged commit 87e82f3 into develop Nov 25, 2022
@mustafapc19 mustafapc19 deleted the feat/docs-for-playwright branch November 25, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong left review comments

@dstala dstala dstala approved these changes

Assignees

@dstala dstala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mustafapc19 @wingkwong @dstala