Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nocodb): handle comparing a date with empty string in pg #4586

Merged
merged 5 commits into from Dec 9, 2022

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Dec 2, 2022

Change Summary

ref: #4546

The correct way to compare with Date should be using IS_AFTER, IS_BEFORE, or IS_SAME which are not supported at this moment. This PR is to prevent empty data returned to UI due to incorrect SQL following Airtable logic.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

IF({DatePaid} == "", "Paid", "Not paid")

image

IF({DatePaid} != "", "Paid", "Not paid")
IF({DatePaid} > "", "Paid", "Not paid")
IF({DatePaid} > "123", "Paid", "Not paid")

image

@wingkwong wingkwong marked this pull request as ready for review December 3, 2022 04:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Uffizzi Preview deployment-8685 was deleted.

@wingkwong wingkwong merged commit 4bbcec8 into develop Dec 9, 2022
@wingkwong wingkwong deleted the fix/if-formula-with-date-empty-string branch December 9, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants