New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nc-gui): nc-icon positions #4975

Merged

dstala merged 2 commits into develop from fix/nc-icon-positions

Jan 31, 2023

Member

wingkwong commented Jan 31, 2023

Change Summary

icons should be inline (fixes: 🐛 Bug: nc-icon display issues #4974)

Change type

feat: (new feature for the user, not a new feature for build script)
fix: (bug fix for the user, not a fix to a build script)
docs: (changes to the documentation)
style: (formatting, missing semi colons, etc; no production code change)
refactor: (refactoring production code, eg. renaming a variable)
test: (adding missing tests, refactoring tests; no production code change)
chore: (updating grunt tasks etc; no production code change)

Test/ Verification

wingkwong added 2 commits

January 31, 2023 13:15


          fix(nc-gui): nc-icon should be inline

9b815f2


          fix(nc-gui): override nc-icon styles for copy and delete icons

96ede7a

wingkwong requested a review from dstala

January 31, 2023 05:17

wingkwong assigned dstala

Contributor

github-actions bot commented Jan 31, 2023 •

edited

Uffizzi Preview deployment-12844 was deleted.

dstala approved these changes

View reviewed changes

dstala merged commit 1578efa into develop

dstala deleted the fix/nc-icon-positions branch

January 31, 2023 07:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment