Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This diff adds support for MySQL to the Helm chart used to deploy NocoDB on Kubernetes. Specifically, it makes the following changes:
In Chart.yaml, it adds a new dependency on the MySQL chart from the Bitnami repository, and sets a condition for enabling it (mysql.enabled).
In values.yaml, it adds a new environment variable (NC_DB) that specifies the connection string for the MySQL database. It also adds a new section for configuring the MySQL chart, including authentication credentials and persistence settings. The enabled flag for MySQL is set to false by default.
Overall, this change allows users to deploy NocoDB using MySQL as the underlying database instead of Postgres, providing more options for managing the application's data.
Change type
Test/ Verification
Tested l in a deployed scenario with a custom dockerfile / helm-chart on a k3s.