Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mysql to helm chart #5162

Merged
merged 1 commit into from May 1, 2023
Merged

Conversation

GentleGhostCoder
Copy link
Contributor

Change Summary

This diff adds support for MySQL to the Helm chart used to deploy NocoDB on Kubernetes. Specifically, it makes the following changes:

In Chart.yaml, it adds a new dependency on the MySQL chart from the Bitnami repository, and sets a condition for enabling it (mysql.enabled).
In values.yaml, it adds a new environment variable (NC_DB) that specifies the connection string for the MySQL database. It also adds a new section for configuring the MySQL chart, including authentication credentials and persistence settings. The enabled flag for MySQL is set to false by default.
Overall, this change allows users to deploy NocoDB using MySQL as the underlying database instead of Postgres, providing more options for managing the application's data.

Change type

  • [ x ] feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Tested l in a deployed scenario with a custom dockerfile / helm-chart on a k3s.

@o1lab o1lab merged commit 4bde056 into nocodb:develop May 1, 2023
@GentleGhostCoder GentleGhostCoder deleted the pr_helm_chart_mysql branch May 4, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants