Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up fixes on geodata column and map view #5248

Merged
merged 45 commits into from Mar 16, 2023

Conversation

flisowna
Copy link
Contributor

@flisowna flisowna commented Mar 3, 2023

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

flisowna and others added 30 commits February 27, 2023 14:02
@spaudanjo
Copy link
Contributor

spaudanjo commented Mar 13, 2023

New scope of this PR is now covering this ticket: #5203

cc @wingkwong @flisowna

  • adapt DB type mappings
  • adapt Map Shared View
    • adding a popup so that users can see row details when clicking on marker
    • using public api so that markers/map view do also work when user is not signed in
    • set limit for page size also to 1000 (as it is for non-shared map view)
  • layout and wording improvements in the detail popup/overlay when viewing/editing a geo location cell value
    • Plus, adding buttons for opening a geo location in GMaps and OSM

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In shared view, after changing mapping field from geo to geo2, it still shows Mapped by geo.

image

  • clicking attachment expand button is not working

image

  • update packages/noco-docs/content/en/setup-and-usages/column-types.md for geo data. Search <!-- TODO: add GeoData -->

@spaudanjo
Copy link
Contributor

In shared view, after changing mapping field from geo to geo2, it still shows Mapped by geo.

image

Interesting - will check, thanks!
Btw, I noticed the same problem with Kanban, not sure whether it's still present though on develop

packages/nc-gui/components/cell/GeoData.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/cell/GeoData.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/cell/GeoData.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/smartsheet/Map.vue Outdated Show resolved Hide resolved
packages/nc-gui/composables/useMapViewDataStore.ts Outdated Show resolved Hide resolved
packages/nc-gui/composables/useSharedView.ts Outdated Show resolved Hide resolved
packages/nc-gui/composables/useSharedView.ts Outdated Show resolved Hide resolved
@wingkwong wingkwong merged commit c008f77 into nocodb:develop Mar 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants