Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sort import #5267

Merged
merged 3 commits into from Mar 8, 2023
Merged

refactor: sort import #5267

merged 3 commits into from Mar 8, 2023

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Mar 8, 2023 •
edited

Change Summary

  • introduce import/order

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@wingkwong wingkwong added the trigger-CI force trigger CI even if PR in draft mode label Mar 8, 2023
@wingkwong wingkwong marked this pull request as ready for review March 8, 2023 07:43
@wingkwong wingkwong merged commit 8841eee into develop Mar 8, 2023
21 of 23 checks passed
@wingkwong wingkwong deleted the refactor/sort-import branch March 8, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
trigger-CI force trigger CI even if PR in draft mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wingkwong