Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose #55

Merged
merged 6 commits into from Sep 16, 2018
Merged

Add docker compose #55

merged 6 commits into from Sep 16, 2018

Conversation

bvkatwijk
Copy link
Contributor

@bvkatwijk bvkatwijk commented Sep 15, 2018

Notes:

  • I have altered the test script to pick up environment variables
  • I have altered the entrypoint script to execute the incoming command
  • The original setup.sql gave Query limit exceeded errors, so I've added docker-setup.sql which breaks the insert statements into smaller chunks.
  • Added dev.Dockerfile which includes dev dependencies, I had to add python to the image
  • I set port 3002 to prevent conflicts with current docker setup
  • Initial runs set up a database, runs after it use the existing database. If the data should be cleared, docker-compose down -v can be used. This can be unclear for non-compose users.
  • There are many more available options available (watch mode for dev/testing, ci setup, etc), I've kept it basic for now. I've also not altered the existing docker(file) setup. EDIT: I have altered entrypoint script. Please check whether this is undesirable.

@o1lab
Copy link
Member

o1lab commented Sep 15, 2018

Thank you @bvkatwijk for the detailed and well made notes with PR. I understand less about docker-compose and k8s - learning them now.

Can you please mention why python is included and how changing entrypoint changes behaviour (if any).

@bvkatwijk
Copy link
Contributor Author

While installing dev dependencies of npm I got an error that python is required. Hence the python install. Same for g++ and make packages.

I recommend the docker docs about entrypoint and command mechanics, but loosely in practice entrypoint is what should always happen (e.g. waiting for database), and cmd is a default action (starting the api generation, or running tests, or maybe other actions). Hence I've removed the api generation command from the entrypoint script, and it can be added to the dockerfile (same as in dev.Dockerfile).

@o1lab o1lab merged commit 8ff7382 into nocodb:master Sep 16, 2018
akbarpasha pushed a commit to akbarpasha/nocodb that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants