Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: timezone locale #5689

Merged
merged 43 commits into from May 27, 2023
Merged

refactor: timezone locale #5689

merged 43 commits into from May 27, 2023

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented May 20, 2023 •
edited

Change Summary

original: #5505

P.S As discussed internally, there won't be an upgrader to revise the existing datetime values for this PR. Therefore, a different datetime values will be rendered. Please contact the team in discord to discuss how to get the right values back.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

image

@wingkwong
Merge branch 'develop' into refactor/timezone-locale
975033c
@wingkwong
fix(nocodb): revise MSSQL datetime conversion logic
88ba9c8
@wingkwong
fix(nc-gui): handle copy time
816070d
@wingkwong
fix(nc-gui): inconsistent payload datetime format
980adf3
@wingkwong
fix(nocodb): MSSQL DATEADD formula
b1b5e19
@wingkwong
Revert "Revert "refactor: timezone""
56a6466
@wingkwong
fix(nocodb): add missing data
64427d0
@wingkwong
refactor(nc-gui): move the formula datetime handling to backend
80fcfce
@wingkwong
fix(nocodb): formula datetime issue in _convertDateFormat
f238976
@wingkwong
fix(nocodb): include second in MSSQL DATEADD
3ff04fc
@wingkwong
feat(nocodb): include timezone conversion for MSSQL formula
7010f91
@wingkwong
Merge branch 'develop' into refactor/timezone-locale
7705716
@wingkwong
Merge pull request #5684 from nocodb/revert-5683-revert-5505-refactor…
c7c2336 
…/timezone-locale

Revert "Revert "refactor: timezone""
@wingkwong wingkwong added 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. trigger-CI force trigger CI even if PR in draft mode labels May 20, 2023
wingkwong and others added 15 commits May 21, 2023 00:45
@wingkwong
Merge pull request #5678 from nocodb/fix/mssql-datetime
d9c8fe4 
fix: datetime followup
@wingkwong
refactor(nc-gui): revise comment
3942924
@wingkwong
refactor(nocodb): revise comments
770c34c
@wingkwong
fix(nocodb): MSSQL datetime formula
e147f2c
@wingkwong
fix(nc-gui): incorrect regex for testing YYYY-MM-DD HH:mm
0f814e5
@wingkwong
Merge branch 'develop' into refactor/timezone-locale
17fd0e6
@dstala
test: enable datetime diff for sqlite
05f26be 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala
test: logs cleanup
270a158 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala
test: common routine for browser timezone
7d3e9b3 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@wingkwong
Merge branch 'develop' into refactor/timezone-locale
92383d0
@dstala
test: validate formula API response
63ad4a4 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@wingkwong
fix(nc-gui): send the payload in UTC format
e45e07f
@wingkwong
Merge branch 'refactor/timezone-locale' of https://github.com/nocodb/…
bfee3f3 
…nocodb into refactor/timezone-locale
@wingkwong
fix(nocodb): DATEADD output format
7aff612
@dstala
test: ignore seconds in formula rsp
1049356 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
wingkwong and others added 9 commits May 23, 2023 15:43
@wingkwong
fix(nc-gui): send in UTC when pasting datetime value
4306485
@dstala
test: comments & cleanup
6fe7966 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@wingkwong
Merge branch 'refactor/timezone-locale' of https://github.com/nocodb/…
e2003df 
…nocodb into refactor/timezone-locale
@dstala
test: formula under different browser tz
64487a0 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@wingkwong
fix(nocodb): add missing timezone plugin & revise comments
c2251d7
@dstala
test: cleanup, parallel db's, extDB formula for browser tz
07248da 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala
test: wait for formula cell to render
19cb20d 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@wingkwong
Merge branch 'develop' into refactor/timezone-locale
6b1a853
@wingkwong
Merge branch 'refactor/timezone-locale' of https://github.com/nocodb/…
7a86f53 
…nocodb into refactor/timezone-locale
@wingkwong wingkwong added this to the Next Release: 0.108.0 milestone May 25, 2023
@dstala dstala marked this pull request as ready for review May 26, 2023 04:48
@dstala dstala requested review from pranavxc and dstala May 26, 2023 04:48
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023 •
edited

Uffizzi Preview deployment-26716 was deleted.

@wingkwong wingkwong removed the trigger-CI force trigger CI even if PR in draft mode label May 26, 2023
@wingkwong
Copy link
Member Author

⚠️ DO NOT MERGE even it got approved. I'll merge it right before the last minute of the actual beta release.

@wingkwong wingkwong removed the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label May 27, 2023
@wingkwong wingkwong merged commit b15dbcc into develop May 27, 2023
15 checks passed
@wingkwong wingkwong deleted the refactor/timezone-locale branch May 27, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavxc pranavxc pranavxc left review comments

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Release: 0.108.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wingkwong @pranavxc @dstala