Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nocodb): Fixed filtering boolean visual bug #5705

Merged
merged 1 commit into from May 31, 2023
Merged

fix(nocodb): Fixed filtering boolean visual bug #5705

merged 1 commit into from May 31, 2023

Conversation

nith2001
Copy link
Contributor

Change Summary

See Issue #5648 for context. The changes I made should fix that and remove the dropdown from appearing on the first issue, thereby reducing confusion on why there's a boolean operator selector at the front of the filtering UI.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

When adding a filter group, this is what it looks like:

Screen Shot 2023-05-22 at 6 04 53 PM

Let's say I added a filter at the bottom of the filter group (or filter) and then deleted the top filter. The "Where" word will automatically update.

Before deleting top filter group:
Screen Shot 2023-05-22 at 6 05 35 PM

After deleting top filter group:
Screen Shot 2023-05-22 at 6 05 53 PM

This applies to the nested ones as well.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@nith2001 nith2001 changed the title fix(nocodb): Fixed Issue #5648 filtering boolean visual bug fix(nocodb): Fixed filtering boolean visual bug May 23, 2023
@nith2001
Copy link
Contributor Author

@dstala Could you review my PR?

@dstala dstala merged commit fe14175 into nocodb:develop May 31, 2023
15 checks passed
@nith2001 nith2001 deleted the 5648-filter-group-boolean-bug branch May 31, 2023 07:33
@nith2001
Copy link
Contributor Author

Let's goooooo, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants