Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set refresh-token on login and correction in refresh-token based api #5764

Merged
merged 6 commits into from May 31, 2023
Merged

fix: set refresh-token on login and correction in refresh-token based api #5764

merged 6 commits into from May 31, 2023

Conversation

pranavxc
Copy link
Member

Change Summary

  • Set refresh-token on the login
  • Correction in refresh-token based token generation api

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc
fix: set refresh-token on login and correction in refresh-token based…
215dea8 
… api

Signed-off-by: Pranav C <pranavxc@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023 •
edited

Uffizzi Preview deployment-26999 was deleted.

@pranavxc
fix: remove unnecessary async
66ad987 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
refactor: type correction
268d836 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: add extractProjectId middleware to /me endpoint
78fdabf 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: remove unnecessary debugger statement
8e7cee8 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc requested a review from wingkwong May 31, 2023 08:53
@pranavxc pranavxc merged commit cf3e4be into develop May 31, 2023
12 of 13 checks passed
@pranavxc pranavxc deleted the fix/refresh-token branch May 31, 2023 09:57
@wingkwong wingkwong added this to the Next Release: 0.108.0 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong approved these changes

@mertmit mertmit Awaiting requested review from mertmit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Release: 0.108.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pranavxc @wingkwong @mertmit