-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Links column type #5848
Merged
Merged
Feat: Links column type #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavxc
added
🛑 Status: Do Not Merge
Used in PR only. The PR cannot be merged due to some reasons.
trigger-CI
force trigger CI even if PR in draft mode
labels
Jun 8, 2023
pranavxc
force-pushed
the
feat/ltar-rollup-on-creation
branch
from
June 10, 2023 10:08
997823a
to
74009c7
Compare
dstala
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- drag drop a table for link creation; don't save, cancel instead. add menu if open now displays link as default. should be single line text
-
has-many
link creation succeeds but doesn't create any column - On click over cell outside link, change cell to
select mode
- Link column edit menu, display column type; if we do not wish to allow user to change type, we can still display column type but disable modifications to it
- Discuss if singular/plural configuration required.
- Discuss if we need to display both LTAR & Link field for the same relation in Form view?
-
Delete
on a cell should unlink all - Filters are not supported yet. IMO, we can treat these as rolled up
numbers
& allow filters/sort that are applicable to numbers - Default fall back names when configuration for singular & plural is cleared - can be link/links instead of item/items
- Shared view error on accessing link
Failed to load children list: Cannot read properties of undefined (reading 'type')
- Display name configuration appears twice; good to have it only under
Show more
?
- kanban, link text display - align to the left as other cells do
pranavxc
force-pushed
the
feat/ltar-rollup-on-creation
branch
from
June 14, 2023 17:37
7216017
to
e8f6eab
Compare
pranavxc
force-pushed
the
feat/ltar-rollup-on-creation
branch
from
June 16, 2023 13:56
5701ec6
to
5a9c5c9
Compare
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/nocodb/nocodb/pull/5848 ⚙️ Updating now by workflow run 5455176779. What is Uffizzi? Learn more! |
|
pranavxc
force-pushed
the
feat/ltar-rollup-on-creation
branch
from
June 19, 2023 13:36
86ae0a8
to
6d9dac5
Compare
…TAR by default Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
dstala
approved these changes
Jun 23, 2023
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Remove general information about one-one
Signed-off-by: Pranav C <pranavxc@gmail.com>
…g same item twice Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
pranavxc
changed the title
Feat: On LTAR creation hide LTAR column and show Rollup column by default
Feat: Links column type
Jul 4, 2023
Signed-off-by: Pranav C <pranavxc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🛑 Status: Do Not Merge
Used in PR only. The PR cannot be merged due to some reasons.
trigger-CI
force trigger CI even if PR in draft mode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of