Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCDBOSS-49 - 馃敠 Feature: Translation: "User acount Settings" pages are translated in json file, but the newest release still keep untraslated #6049

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Jul 14, 2023

Change Summary

ref: #5655

1, In latest release, "Full User acount Settings" pages are not tranlated. but Crodin translation page shows these phrases are already translated

2, columnTypes, such as "SingleLine Text", are NOT translate. but Crodin translation page shows these phrases are already translated

Change type

  • feat: Translation: "User acount Settings" pages are translated in json file, but the newest release still keep untranslated

Test/ Verification

Provide summary of changes.
https://www.loom.com/share/72125b95a84a47cabb757df6d9bb049e


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: frankmagoba <franklinmagoba4@gmail.com>
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitstart I don't see the changes related to the second point.

2, columnTypes, such as "SingleLine Text", are NOT translate. but Crodin translation page shows these phrases are already translated

Is this PR only targeting the first point only?

@gitstart
Copy link
Contributor Author

@gitstart I don't see the changes related to the second point.

2, columnTypes, such as "SingleLine Text", are NOT translate. but Crodin translation page shows these phrases are already translated

Is this PR only targeting the first point only?

Yes this is targeting only the first point, I think the second part is already being worked on
#5655 (comment)

@wingkwong wingkwong merged commit 6ca358c into nocodb:develop Jul 14, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants