Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dataloader error and throw proper error and update scripts in package.json #6090

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Avoid dataloader error and throw proper error and update scripts in package.json #6090

merged 2 commits into from
Jul 28, 2023

Conversation

pranavxc
Copy link
Member

@pranavxc pranavxc commented Jul 28, 2023 •
edited

Change Summary

  • Avoid data loader errors to identify the proper error
  • Update package.json scripts

re #5915

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc
fix: throw the actual error and avoid dataloader error to avoid confu…
e731823 
…sion

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
chore: update start and build commands
0ba0e21 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc requested a review from mertmit July 28, 2023 09:03
@github-actions
Copy link
Contributor

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/nocodb/nocodb/pull/6090

⚙️ Updating now by workflow run 5690529057.

What is Uffizzi? Learn more!

@mertmit mertmit merged commit 0132c23 into develop Jul 28, 2023
15 checks passed
@mertmit mertmit deleted the refactor/dataloader-error branch July 28, 2023 09:45
@VrajPatelGitHub VrajPatelGitHub mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertmit mertmit mertmit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pranavxc @mertmit