Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace reference to missing env in docker-compose/traefik #6203

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

fspoettel
Copy link
Contributor

Change Summary

The traefik docker-compose.yml references an env variable CLOUDFLARE_TOKEN that does not exist in the corresponding env file:

https://github.com/nocodb/nocodb/blob/develop/docker-compose/traefik/docker-compose.yml#L65

https://github.com/nocodb/nocodb/blob/develop/docker-compose/traefik/.env#L3

This PR replaces it with the correct env. I chose to update the compose file instead of the env file because the CF_DNS_API_TOKEN name is easier to google in order to figure out permissions needed for the token.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

docker compose up should result in traefik being able to acquire an SSL cert.

Additional information / screenshots (optional)

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023

CLA assistant check
All committers have signed the CLA.

@o1lab o1lab merged commit 3c247e7 into nocodb:develop Aug 21, 2023
1 check passed
@fspoettel fspoettel deleted the fix/traefik-cf-env branch August 21, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants