Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cannot send multiple user invites to a project by separating with a comma #6275

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Aug 31, 2023

Change Summary

#closes: #6267

Steps to reproduce ?

  1. Go to a project´s collaborators' view
  2. In the invite section, Input more than one email, separated by a comma, and click the "Add User/s" button:
  3. The error "/email - must match format "email"" will appear:

Sending only 1 invite works fine. The problem is trying to append multiple emails with a comma.

Desired Behavior

As suggested in the documentation, we expect to be able to invite more than one user with a single action.
The documentation here suggests that invitations can be sent if we separate emails with a comma:

However, it seems that a validation is being done, preventing the feature from working. We think that the validation might be a swagger one here

Change type

  • feat: Enable validation and invite function for multiple emails

Test/ Verification

Provide summary of changes.
https://www.loom.com/share/4c42ae53705641e7acb0ac6d10414e79


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: frankmagoba <franklinmagoba4@gmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@gitstart gitstart changed the title NCDBOSS-71 - 🐛 Bug: Cannot send multiple user invites to a project by separating with a comma Bug: Cannot send multiple user invites to a project by separating with a comma Aug 31, 2023
@gitstart gitstart marked this pull request as ready for review August 31, 2023 07:39
@gitstart gitstart marked this pull request as draft August 31, 2023 08:28
Co-authored-by: frankmagoba <franklinmagoba4@gmail.com>
Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@gitstart gitstart marked this pull request as ready for review August 31, 2023 08:58
@gitstart gitstart marked this pull request as draft August 31, 2023 09:12
@gitstart gitstart marked this pull request as ready for review August 31, 2023 09:13
@dstala dstala self-requested a review August 31, 2023 09:18
@dstala dstala requested a review from pranavxc August 31, 2023 09:19
@pranavxc pranavxc merged commit 2a985cb into nocodb:develop Aug 31, 2023
35 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Cannot send multiple user invites to a project by separating with a comma
3 participants