Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: default value not applied if value was modified before submitting link shared form #6472

Merged
merged 7 commits into from
Oct 27, 2023

Conversation

gitstart
Copy link
Contributor

Change Summary

closes: #6372

There is a new record created with value 443 in the column port, because the field from the form was empty.

Change type

  • fix: (bug fix for the user, not a fix to a build script)

Test/ Verification

https://www.loom.com/share/0ee56f5727404da58ead957218af5b1f

Provide summary of changes.

Additional information / screenshots (optional)


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

gitstart and others added 5 commits September 25, 2023 13:15
…ing link shared form

Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: sheldon-welinga <sheldonwelinga@gmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
Co-authored-by: frankmagoba <franklinmagoba4@gmail.com>
Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: sheldon-welinga <sheldonwelinga@gmail.com>
Co-authored-by: frankmagoba <franklinmagoba4@gmail.com>
Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: sheldon-welinga <sheldonwelinga@gmail.com>
@dstala dstala requested a review from pranavxc October 21, 2023 09:37
@dstala
Copy link
Member

dstala commented Oct 21, 2023

@gitstart could you help us by creating a new PR. I merged develop on your branch & now over here - its showing 1311 files changed instead of original 2 files. Apologies.

@dstala
Copy link
Member

dstala commented Oct 21, 2023

i have verified scenario & it works as intended.

@dstala dstala added this to the vNext milestone Oct 21, 2023
gitstart and others added 2 commits October 23, 2023 09:55
…g link shared form

Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: sheldon-welinga <sheldonwelinga@gmail.com>
Co-authored-by: frankmagoba <franklinmagoba4@gmail.com>
@gitstart
Copy link
Contributor Author

@gitstart could you help us by creating a new PR. I merged develop on your branch & now over here - its showing 1311 files changed instead of original 2 files. Apologies.

Hi @dstala ,
The branch has been updated.
thank you

@dstala dstala merged commit 674ecb8 into nocodb:develop Oct 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: default value not applied if value was modified before submitting link shared form
3 participants