Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nocodb): rowId issue after in audit log #6592

Merged
merged 2 commits into from Oct 6, 2023
Merged

fix(nocodb): rowId issue after in audit log #6592

merged 2 commits into from Oct 6, 2023

Conversation

reenphygeorge
Copy link
Contributor

Change Summary

  • fixed Row ID not showing on DELETE

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

@reenphygeorge reenphygeorge linked an issue Oct 6, 2023 that may be closed by this pull request
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Uffizzi Preview deployment-37830 was deleted.

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the test.

  1) Model
       BaseModelSql
         Delete record:
     AssertionError: expected { Object (id, user, ...) } to have property 'row_id' of '1', but got null
      at Context.<anonymous> (tests/unit/model/tests/baseModelSql.test.ts:293:32)

Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala dstala merged commit dea6f6e into develop Oct 6, 2023
22 checks passed
@dstala dstala deleted the fix/rowId branch October 6, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Audit Log - Row ID not showing on DELETE
3 participants