chore: exclude pw package.json #6672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingkwong
requested changes
Oct 11, 2023
There was a problem hiding this comment.
if you exclude it and run pnpm i after running scripts/upgradeNocodbSdk.js, pnpm won't be able to find nocodb-sdk in pr / nightly build case since name in nocodb-sdk/package.json is changed to nocodb-sdk-daily unless you can make sure each install doesn't include pw. With the changes in this PR, I bet it would fail in release-docker.yml L104. You may try nightly build once on your branch to verify.
Signed-off-by: mertmit <mertmit99@gmail.com>
mertmit
force-pushed
the
chore/exclude-pw
branch
from
ee20a88
to
2b80d18
Compare
|
Thank you for pointing out, |
wingkwong
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change type