Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSON cell height based on user selected row height #6705

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: JSON cell height based on user selected row height #6705

merged 2 commits into from
Oct 18, 2023

Conversation

pranavxc
Copy link
Member

@pranavxc pranavxc commented Oct 16, 2023 •
edited

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc
fix: json cell height
8861d88 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc requested a review from dstala October 16, 2023 19:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited

Uffizzi Preview deployment-38632 was deleted.

dstala
dstala requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@dstala dstala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From edit mode, click outside should close the expanded JSON cell

@pranavxc pranavxc requested a review from dstala October 18, 2023 09:12
@dstala dstala merged commit b0dc1a4 into develop Oct 18, 2023
22 checks passed
@dstala dstala deleted the fix/json-cell-row-height branch October 18, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pranavxc @dstala @DarkPhoenix2704