Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: logic for replacing version #6759

Merged
merged 3 commits into from
Nov 20, 2023
Merged

chore: logic for replacing version #6759

merged 3 commits into from
Nov 20, 2023

Conversation

mertmit
Copy link
Member

@mertmit mertmit commented Oct 20, 2023

Change Summary

  • Depending on workspace: ^ we need to manually push that change to master after release, we can instead use package name to replace the version
    (see rn after the release master have versions instead of workspace: ^)
  • Add --ignore-workspace for pnpm install of nocodb-sdk as we need to publish before bumping other packages

Change type

  • chore: (updating grunt tasks etc; no production code change)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Uffizzi Ephemeral Environment deployment-39080

☁️ https://app.uffizzi.com/github.com/nocodb/nocodb/pull/6759

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using a release version, then all sdk changes done in locally won't reflect in local dev, fe & be will take the version of the release one instead of local one.

@mertmit
Copy link
Member Author

mertmit commented Oct 28, 2023

Yes we should definitely target local after releases (even we can improve our release action to revert it back when finished) but imo it shouldn't break the release actions if something goes wrong with that.
So if this doesn't cause an extra issue might be good to have.

Signed-off-by: mertmit <mertmit99@gmail.com>
Signed-off-by: mertmit <mertmit99@gmail.com>
Signed-off-by: mertmit <mertmit99@gmail.com>
@mertmit mertmit merged commit 276dcbf into develop Nov 20, 2023
1 check passed
@mertmit mertmit deleted the chore/upgrade-sdk branch November 20, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants