Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SDK for attachment type not working in node environment #6854

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Nov 1, 2023

Change Summary

closes: #6062

SDK for attachment type not working in node environment

Change type

  • feat: SDK for attachment type not working in node environment

Test/ Verification

Provide summary of changes.
https://www.loom.com/share/757a3fad94714385a82bc75aab389a59

Additional information / screenshots (optional)


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: sheldon-welinga <sheldonwelinga@gmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@dstala dstala requested a review from pranavxc November 2, 2023 12:12
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge after passing CI/CD.

@wingkwong wingkwong merged commit d2bc862 into nocodb:develop Nov 5, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: SDK for attachment type not working in node environment
3 participants