feat: Monday as first day of week in calendar popup #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: frankmagoba <franklinmagoba4@gmail.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
pranavxc
requested changes
Nov 6, 2023
There was a problem hiding this comment.
The behaviour should be same for DatetimePicker component as well.
It works fine if there is a DatePicker since the change done is globally applied.
So I would prefer to move the datejs change globally somewhere which runs independently globally.
dayjs.extend(updateLocale)
dayjs.updateLocale('en', {
weekStart: 1,
})Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: frankmagoba <franklinmagoba4@gmail.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
pranavxc
reviewed
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
closes: #5988
Monday as first day of week in calendar popup
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.