refactor: Include request context in app-hooks #6894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
o1lab
force-pushed
the
nc-fix/test-connection
branch
6 times, most recently
from
c0cce4d
to
a363584
Compare
o1lab
force-pushed
the
nc-fix/test-connection
branch
from
a363584
to
1e48b62
Compare
wingkwong
reviewed
Nov 7, 2023
| @@ -19,10 +26,13 @@ export class FormColumnsController { | |||
| async columnUpdate( | |||
| @Param('formViewColumnId') formViewColumnId: string, | |||
| @Body() formViewColumnbody: FormColumnUpdateReqType, | |||
|
|
|||
| @Request() req: any, | |||
There was a problem hiding this comment.
can use RequestType instead of any? (apply to all)
There was a problem hiding this comment.
I will update this part as well in a followup pr... and inside hook I will use a custom type since in some case only certain fields we are passing ( user, headers, etc... )
At the moment we are not using it in OSS but later it will be helpful to extract data for Audit and listeners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of