Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid applying default view filter and sort if viewId is not passed #6941

Merged
merged 5 commits into from
Nov 13, 2023
Merged

fix: Avoid applying default view filter and sort if viewId is not passed #6941

merged 5 commits into from
Nov 13, 2023

Conversation

pranavxc
Copy link
Member

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc pranavxc changed the title fix: void applying default view filter and sort if viewId is not passed fix: Avoid applying default view filter and sort if viewId is not passed Nov 10, 2023
@pranavxc pranavxc requested a review from dstala November 10, 2023 06:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023 •
edited

Uffizzi Preview deployment-40485 was deleted.

@pranavxc pranavxc added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 10, 2023
@pranavxc pranavxc removed the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 13, 2023
@wingkwong wingkwong merged commit 78cae5c into develop Nov 13, 2023
22 checks passed
@wingkwong wingkwong deleted the fix/avoid-applying-default-view-filter branch November 13, 2023 08:55
This was referenced Nov 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong approved these changes

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pranavxc @wingkwong @dstala