-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Missing formula functions support #7019
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavxc
added
🛑 Status: Do Not Merge
Used in PR only. The PR cannot be merged due to some reasons.
trigger-CI
force trigger CI even if PR in draft mode
labels
Nov 17, 2023
pranavxc
changed the title
feat: Missing formula support
feat: Missing formula functions support
Nov 17, 2023
o1lab
force-pushed
the
nc-feat/missing-formulas
branch
19 times, most recently
from
November 21, 2023 07:19
caa1de9
to
e438e4d
Compare
wingkwong
reviewed
Nov 21, 2023
o1lab
force-pushed
the
nc-feat/missing-formulas
branch
7 times, most recently
from
November 21, 2023 19:15
86f3857
to
0a4bfa1
Compare
o1lab
force-pushed
the
nc-feat/missing-formulas
branch
from
November 22, 2023 07:18
7c81816
to
6e617ce
Compare
wingkwong
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COUNTA({number})
ROUNDUP({number})
ROUNDDOWN({number})
TypeError: Cannot read properties of undefined (reading 'builder') (resolved after cleaning node_modules and restart)
Node: **v18.14.0**
Arch: **arm64**
Platform: **darwin**
Docker: **false**
RootDB: **pg**
PackageVersion: **0.202.8**
wingkwong
reviewed
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of