Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Missing formula functions support #7019

Merged
merged 42 commits into from
Nov 22, 2023
Merged

Conversation

pranavxc
Copy link
Member

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc pranavxc added 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. trigger-CI force trigger CI even if PR in draft mode labels Nov 17, 2023
@pranavxc pranavxc changed the title feat: Missing formula support feat: Missing formula functions support Nov 17, 2023
@o1lab o1lab force-pushed the nc-feat/missing-formulas branch 19 times, most recently from caa1de9 to e438e4d Compare November 21, 2023 07:19
@o1lab o1lab force-pushed the nc-feat/missing-formulas branch 7 times, most recently from 86f3857 to 0a4bfa1 Compare November 21, 2023 19:15
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COUNTA({number})
ROUNDUP({number})
ROUNDDOWN({number})

TypeError: Cannot read properties of undefined (reading 'builder') (resolved after cleaning node_modules and restart)

Node: **v18.14.0**
Arch: **arm64**
Platform: **darwin**
Docker: **false**
RootDB: **pg**
PackageVersion: **0.202.8**

@pranavxc pranavxc merged commit 282b8f4 into develop Nov 22, 2023
22 checks passed
@pranavxc pranavxc deleted the nc-feat/missing-formulas branch November 22, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trigger-CI force trigger CI even if PR in draft mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants