Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate select options before insert #7070

Merged
merged 6 commits into from
Nov 25, 2023
Merged

fix: Validate select options before insert #7070

merged 6 commits into from
Nov 25, 2023

Conversation

pranavxc
Copy link
Member

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc pranavxc added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 23, 2023
@pranavxc pranavxc requested a review from dstala November 23, 2023 10:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited

Uffizzi Preview deployment-41341 was deleted.

dstala
dstala requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@dstala dstala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fix for v2

@dstala
test: remove trailing space when defining options
2220b49 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala
test: remove trailing space during select field creation
2233991 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala
Copy link
Member

dstala commented Nov 24, 2023

  • rename select using add/edit menu. validation kicks in & triggers a false error

@dstala dstala merged commit 42be112 into develop Nov 25, 2023
22 checks passed
@dstala dstala deleted the fix/5492-validate-select-options branch November 25, 2023 06:10
@dstala dstala mentioned this pull request Nov 25, 2023
Closed
1 task
@Kiss-World
Copy link

API still can't import content that doesn't exist in a singleselect or multiple selection。This function is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pranavxc @dstala @Kiss-World