Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX fixes - 2 #7218

Merged
merged 40 commits into from Dec 20, 2023
Merged

UI/UX fixes - 2 #7218

merged 40 commits into from Dec 20, 2023

Conversation

rameshmane7218
Copy link
Collaborator

@rameshmane7218 rameshmane7218 commented Dec 13, 2023

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@rameshmane7218 rameshmane7218 added the trigger-CI force trigger CI even if PR in draft mode label Dec 13, 2023
@wingkwong wingkwong changed the title UI/UX fixes - 2 #7210 UI/UX fixes - 2 Dec 14, 2023
o1lab and others added 23 commits December 15, 2023 16:12
* New translations en.json (French)

* New translations en.json (Spanish)

* New translations en.json (Arabic)

* New translations en.json (Czech)

* New translations en.json (Danish)

* New translations en.json (German)

* New translations en.json (Basque)

* New translations en.json (Finnish)

* New translations en.json (Hebrew)

* New translations en.json (Italian)

* New translations en.json (Japanese)

* New translations en.json (Korean)

* New translations en.json (Dutch)

* New translations en.json (Norwegian)

* New translations en.json (Polish)

* New translations en.json (Portuguese)

* New translations en.json (Russian)

* New translations en.json (Slovak)

* New translations en.json (Slovenian)

* New translations en.json (Swedish)

* New translations en.json (Turkish)

* New translations en.json (Ukrainian)

* New translations en.json (Chinese Simplified)

* New translations en.json (Chinese Traditional)

* New translations en.json (English)

* New translations en.json (Vietnamese)

* New translations en.json (Portuguese, Brazilian)

* New translations en.json (Indonesian)

* New translations en.json (Persian)

* New translations en.json (Thai)

* New translations en.json (Croatian)

* New translations en.json (Latvian)

* New translations en.json (Hindi)

* New translations en.json (Bengali, India)

* Update source file en.json
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: mertmit <mertmit99@gmail.com>
Signed-off-by: mertmit <mertmit99@gmail.com>
Signed-off-by: mertmit <mertmit99@gmail.com>
Signed-off-by: mertmit <mertmit99@gmail.com>
@rameshmane7218 rameshmane7218 self-assigned this Dec 18, 2023
@rameshmane7218 rameshmane7218 marked this pull request as ready for review December 18, 2023 12:19
Copy link
Contributor

github-actions bot commented Dec 18, 2023

Uffizzi Preview deployment-43197 was deleted.

@rameshmane7218 rameshmane7218 removed the trigger-CI force trigger CI even if PR in draft mode label Dec 18, 2023
@rameshmane7218 rameshmane7218 marked this pull request as draft December 19, 2023 03:59
@rameshmane7218 rameshmane7218 added the trigger-CI force trigger CI even if PR in draft mode label Dec 19, 2023
@rameshmane7218 rameshmane7218 marked this pull request as ready for review December 19, 2023 08:58
@rameshmane7218 rameshmane7218 removed the trigger-CI force trigger CI even if PR in draft mode label Dec 19, 2023
Copy link
Member

@mertmit mertmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also handle when we click New record - Form on grid Save is grayed out but I might want to save with initial state (with default values only)

Comment on lines 101 to 102
const defalutValue = col.cdf
acc[col.title!] = typeof defalutValue === 'string' ? defalutValue.replace(/^'/, '').replace(/'$/, '') : defalutValue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a small typo on variable name you might want to refactor

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update that

@rameshmane7218
Copy link
Collaborator Author

Can you also handle when we click New record - Form on grid Save is grayed out but I might want to save with initial state (with default values only)

Ya sure, I will enable save button

@dstala dstala merged commit ff61e9f into develop Dec 20, 2023
22 checks passed
@dstala dstala deleted the fix/ui-ux-2 branch December 20, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: UI/UX fixes - 2
7 participants