Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nc-gui): Hide Rename, Delete, Add record buttons when user doesn't have necessary permissions #7871

Merged
merged 2 commits into from Mar 16, 2024

Conversation

IFGGit
Copy link
Contributor

@IFGGit IFGGit commented Mar 14, 2024

Change Summary

  • Hide Add record button when user doesn't have dataInsert permission.
    Button "Add record" opens form with disabled fields and you can't submit this form.

  • Remove tableRename, tableDelete from org level role permissions for hiding Rename and Delete buttons in table context menu.
    Hide buttons which perform actions that are not allowed by backend.
    Remove tableRename, tableDelete from org level because these permissions are not related to org level actions.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

I tested all the changes.

Additional information / screenshots (optional)

Screenshot 2024-03-14 at 23 55 48 Added screenshot for first problem

@dstala dstala requested a review from pranavxc March 15, 2024 06:12
@dstala dstala merged commit 6241423 into nocodb:develop Mar 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants